Merged
Conversation
Release 0.24.0
The glob pattern `electron/out/make/*.zip` did not match the actual
output path from Electron Forge, which places macOS builds at
`electron/out/make/zip/darwin/{arch}/*.zip`.
Changed to recursive glob `**/*.zip` to find zip files in subdirectories.
This fixes the missing macOS Electron build in releases.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
github
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The v0.24.0 release was missing the macOS Electron build (
.zip). Investigation of the workflow logs showed:electron/out/make/zip/darwin/arm64/DigiScript-darwin-arm64-0.24.0.zipNo files were found with the provided path: electron/out/make/*.zipRoot Cause
Electron Forge outputs macOS builds to a nested directory structure (
make/zip/darwin/{arch}/), but the workflow used a non-recursive glob pattern (*.zip) that only matched files directly inmake/.Fix
Changed the artifact pattern from
electron/out/make/*.ziptoelectron/out/make/**/*.zipto recursively find zip files in subdirectories.Test plan
🤖 Generated with Claude Code